feat(storage): support delete source objects on compose - #4360
feat(storage): support delete source objects on compose#4360nidhiii-27 wants to merge 8 commits into
Conversation
Updates compose file sample to support deleting source objects optionally. Fixes b/441557254 [Generated-by: AI]
nidhiii-27
added
ai-generated
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new sample script 'storage/composeFile.js' to demonstrate how to combine multiple files into a single destination file using the Google Cloud Storage API, along with corresponding integration tests in 'storage/system-test/files.test.js'. The feedback suggests correcting a copy-paste error in the JSDoc header that references Access Control Lists instead of file composition, and dynamically joining the source file names in the console log messages rather than hardcoding them.
product-auto-label
Bot
added
api: storage
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
Some presubmits are failing, can you check ? |
Update composeFile sample to pass deleteSourceObjects option to combine method instead of deleting them manually. [Generated-by: AI]
Make main async and await composeFile to prevent premature process exit. Correctly set process.exitCode on error to propagate failures. [Generated-by: AI]
…e sample The compose sample was failing in CI because the deleteSourceObjects option in Bucket.combine was added in a recent version of @google-cloud/storage (7.21.0). The package.json was previously allowing 7.19.0+ which did not have this feature. Also improved error handling in the sample to ensure non-zero exit codes on failure. [Generated-by: AI]
2 participants
Updates compose file sample to support deleting source objects optionally. Fixes b/441557254